pan3793 commented on code in PR #3262:
URL: https://github.com/apache/parquet-java/pull/3262#discussion_r2290272734
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -943,6 +965,51 @@ public ParquetFileReader(InputFile file,
ParquetReadOptions options, SeekableInp
f.close();
throw e;
}
+
+ this.fileMetaData = footer.getFileMetaData();
Review Comment:
@wgtmac I'm afraid we can not do that
<img width="1002" height="949" alt="image"
src="https://github.com/user-attachments/assets/a500b806-526b-463b-9723-b1521a1bbbbb";
/>
I also tried to make `ParquetMetadata footer` nullable, and read from the
file when `footer` is NULL, but this does not work either, because some places
pass NULL explicitly.
To completely fix the code duplication issue of `ParquetFileReader`, I think
we should introduce a `Builder` for it, but this is out of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
