wgtmac commented on code in PR #3270:
URL: https://github.com/apache/parquet-java/pull/3270#discussion_r2296560141
##########
parquet-column/src/main/java/org/apache/parquet/column/values/plain/BinaryPlainValuesReader.java:
##########
@@ -27,6 +27,14 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+/**
+ * ValuesReader for variable-length {@code BYTE_ARRAY} columns.
Review Comment:
I don't think this is the good place to add the comment since this class is
for a specific encoding of binary physical type.
As I have replied in the issue, the spec is clear on this so we don't even
need the explaination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
