ArnavBalyan commented on code in PR #3269:
URL: https://github.com/apache/parquet-java/pull/3269#discussion_r2297303306
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1804,14 +1804,27 @@ private static void copy(SeekableInputStream from,
PositionOutputStream to, long
* @throws IOException if there is an error while writing
*/
public void end(Map<String, String> extraMetaData) throws IOException {
+ final long footerStart = out.getPos();
+
+ // Build the footer metadata) in memory using the helper stream
+ InMemoryPositionOutputStream buffer = new
InMemoryPositionOutputStream(footerStart);
+
+ serializeColumnIndexes(columnIndexes, blocks, buffer, fileEncryptor);
+ serializeOffsetIndexes(offsetIndexes, blocks, buffer, fileEncryptor);
+ serializeBloomFilters(bloomFilters, blocks, buffer, fileEncryptor);
+
+ ParquetMetadata localFooter =
+ new ParquetMetadata(new FileMetaData(schema, extraMetaData,
Version.FULL_VERSION), blocks);
+ serializeFooter(localFooter, buffer, fileEncryptor, metadataConverter);
+
+ byte[] footerBytes = buffer.toByteArray();
+
try {
+ out.write(footerBytes);
+ out.flush();
Review Comment:
Yes that's a good point, the state change can be done before flushing the
buffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
