cashmand commented on code in PR #520:
URL: https://github.com/apache/parquet-format/pull/520#discussion_r2300904664
##########
VariantShredding.md:
##########
@@ -192,31 +202,31 @@ optional group event (VARIANT) {
The group for each named field must use repetition level `required`.
-A field's `value` and `typed_value` are set to null (missing) to indicate that
the field does not exist in the variant.
-To encode a field that is present with a null value, the `value` must contain
a Variant null: basic type 0 (primitive) and physical type 0 (null).
+A field's `value` and `typed_value` are both missing to indicate that the
field does not exist in the variant.
+To encode a field that is present with a SQL NULL value, the `value` must
contain a Variant null: basic type 0 (primitive) and physical type 0 (null).
-When both `value` and `typed_value` for a field are non-null, engines should
fail.
+When both `value` and `typed_value` for a field are present, engines should
fail.
Review Comment:
Agreed, I think this is wrong. I think it's trying to describe the case
where `typed_value` is an array or scalar. I'm not sure how to word it
succinctly and clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
