ArnavBalyan commented on PR #3283: URL: https://github.com/apache/parquet-java/pull/3283#issuecomment-3236230405
> @ArnavBalyan, unfortunately, we do not have end-to-end tests for parquet-cli. Were you able to validate this manually? > > * Are the conf key-value pairs really reach the related code path at different commands? > * Is the `--conf` argument properly described in the help? > > It looks good to me otherwise. Thank you so much for the review, I'll check if we can add some more end to end tests for the CLI. I verified manually that the configs are correctly reaching the other side to the command, example output from one of the manual logs: ``` log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. === CONVERT COMMAND CONFIGURATION RECEIVED === CONFIG: parquet.avro.write-parquet-uuid = true CONFIG: parquet.avro.write-old-list-structure = false CONFIG: test.property = test.value Total configuration properties available: 925 === END CONVERT COMMAND CONFIGURATION === [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.413 s -- in org.apache.parquet ``` The above configs were passed through the --config option. It seems to be well described in help, pls let me know if we should add anything else thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
