ArnavBalyan commented on code in PR #3297: URL: https://github.com/apache/parquet-java/pull/3297#discussion_r2313983831
########## dev/prepare-release.sh: ########## @@ -39,6 +39,6 @@ new_development_version="$release_version-SNAPSHOT" tag="apache-parquet-$release_version-rc$2" ./mvnw release:clean -./mvnw release:prepare -DskipTests -Darguments=-DskipTests -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version" +./mvnw release:prepare -Pvector-plugins -DskipTests -Darguments=-DskipTests -Dtag="$tag" "-DreleaseVersion=$release_version" -DdevelopmentVersion="$new_development_version" Review Comment: Thanks thats a great find @pan3793! I think the solution may depend on whether we want to include `vector-plugins` in our releases. It seems the current behaviour is not to include vector-plugins. Reverting this should continue maintaining this behaviour (not sure how it got included this time as vector-plugins is not included by default) Optionally if we want to include vector-plugins in the releases, release script can be updated to include it conditionally on the JDK being used. Maybe have an automatic CI job for releases to avoid dev overhead. @wgtmac @Fokko what do you think? Can take next steps accordingly thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
