ArnavBalyan commented on code in PR #3287:
URL: https://github.com/apache/parquet-java/pull/3287#discussion_r2322805746
##########
parquet-cli/src/main/java/org/apache/parquet/cli/BaseCommand.java:
##########
@@ -55,14 +56,56 @@
import org.apache.parquet.cli.util.GetClassLoader;
import org.apache.parquet.cli.util.Schemas;
import org.apache.parquet.cli.util.SeekableFSDataInputStream;
+import org.apache.parquet.example.data.Group;
+import org.apache.parquet.hadoop.ParquetFileReader;
import org.apache.parquet.hadoop.ParquetReader;
+import org.apache.parquet.hadoop.example.GroupReadSupport;
import org.slf4j.Logger;
public abstract class BaseCommand implements Command, Configurable {
private static final String RESOURCE_URI_SCHEME = "resource";
private static final String STDIN_AS_SOURCE = "stdin";
+ /**
+ * Note for dev: Due to legancy reasons, parquet-cli used the avro schema
reader which
+ * breaks for files generated through proto. This logic is in place to
auto-detect such cases
Review Comment:
Agreed, have added a config to allow user side enablement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
