jerolba commented on code in PR #3301:
URL: https://github.com/apache/parquet-java/pull/3301#discussion_r2326651601
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java:
##########
@@ -476,6 +477,9 @@ public abstract static class Builder<T, SELF extends
Builder<T, SELF>> {
private boolean enableValidation = DEFAULT_IS_VALIDATING_ENABLED;
private ParquetProperties.Builder encodingPropsBuilder =
ParquetProperties.builder();
+ protected Builder() {}
+
+ @Deprecated
Review Comment:
I've added the @Deprecated annotation to make it consistent with
`ParquetReader`
[builder](https://github.com/apache/parquet-java/blob/4f577a6b64f491d62a2b4bc2acf93d82342f525c/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java#L217)
where `protected Builder(Path path)` constructor is also deprecated.
My understanding is that the roadmap includes removing `Path` usage in
Parquet to avoid Hadoop dependencies.
As you say, the change is not related with the objective of the PR and I can
remove it and open an issue to discuss the topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
