gszadovszky commented on code in PR #3314: URL: https://github.com/apache/parquet-java/pull/3314#discussion_r2352399219
########## pom.xml: ########## @@ -69,8 +69,8 @@ </mailingLists> <properties> - <maven.compiler.source>1.8</maven.compiler.source> - <maven.compiler.target>1.8</maven.compiler.target> + <maven.compiler.source>11</maven.compiler.source> + <maven.compiler.target>11</maven.compiler.target> Review Comment: I think we should start using `maven.compiler.release` instead. ########## parquet-plugins/parquet-encoding-vector/pom.xml: ########## @@ -35,7 +35,7 @@ <url>https://parquet.apache.org</url> <properties> - <!-- Those properties prevent java 8 to try and compile this code --> + <!-- Those properties prevent Java 11 to try and compile this code --> <maven.compiler.source>17</maven.compiler.source> <maven.compiler.target>17</maven.compiler.target> Review Comment: See the comment in the root pom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
