gszadovszky commented on code in PR #3325:
URL: https://github.com/apache/parquet-java/pull/3325#discussion_r2374493098
##########
parquet-column/src/main/java/org/apache/parquet/internal/filter2/columnindex/ColumnIndexFilter.java:
##########
@@ -220,4 +225,35 @@ public RowRanges visit(Not not) {
throw new IllegalArgumentException(
"Predicates containing a NOT must be run through
LogicalInverseRewriter. " + not);
}
+
+ /**
+ * Validates that column index and offset index metadata are consistent and
can be used safely.
+ *
+ * @param columnIndex the column index to validate
+ * @param offsetIndex the offset index to validate
+ * @param columnPath the column path for error reporting
+ * @return true if metadata is valid and safe to use, false if corrupt and
should be ignored
+ */
+ private static boolean isValidMetadata(ColumnIndex columnIndex, OffsetIndex
offsetIndex, ColumnPath columnPath) {
+ if (columnIndex == null || offsetIndex == null) {
+ return true;
+ }
Review Comment:
Based on the code it seems they cannot be null at this stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
