gszadovszky commented on code in PR #3339:
URL: https://github.com/apache/parquet-java/pull/3339#discussion_r2386854650
##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowBloomFilterCommand.java:
##########
@@ -63,14 +67,31 @@ public ShowBloomFilterCommand(Logger console) {
required = true)
List<String> testValues;
+ @Parameter(
+ names = {"--footer-key"},
+ description = "Footer key for encrypted files (hex string, 16/24/32
bytes)")
+ String footerKeyHex;
+
+ @Parameter(
+ names = {"--column-key"},
+ description = "Column key for encrypted files (hex string, 16/24/32
bytes)")
+ String columnKeyHex;
Review Comment:
Cannot the column key be different for each column?
##########
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowBloomFilterCommand.java:
##########
@@ -63,14 +67,31 @@ public ShowBloomFilterCommand(Logger console) {
required = true)
List<String> testValues;
+ @Parameter(
+ names = {"--footer-key"},
+ description = "Footer key for encrypted files (hex string, 16/24/32
bytes)")
+ String footerKeyHex;
+
+ @Parameter(
+ names = {"--column-key"},
+ description = "Column key for encrypted files (hex string, 16/24/32
bytes)")
+ String columnKeyHex;
+
Review Comment:
@ArnavBalyan, is it only bloom filters? Shouldn't we add this at a more
common level, so other commands would also benefit from it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
