ostronaut commented on code in PR #523:
URL: https://github.com/apache/parquet-format/pull/523#discussion_r2429054451


##########
VariantShredding.md:
##########
@@ -214,9 +214,9 @@ The table below shows how the series of objects in the 
first column would be sto
 | `{ }`                                                                        
      | null                              | non-null      | null                
           | null                                 | null                        
 | null                               | Object is present but empty             
         |
 | null                                                                         
      | `00` (null)                       | null          |                     
           |                                      |                             
 |                                    | Object/value is null                    
         |
 | missing                                                                      
      | null                              | null          |                     
           |                                      |                             
 |                                    | Object/value is missing                 
         |
-| INVALID                                                                      
      | `{"event_type": "login"}`         | non-null      | null                
           | `login`                              | null                        
 | 1729795057774                      | INVALID: Shredded field is present in 
`value`    |
-| INVALID                                                                      
      | `"a"`                             | non-null      | null                
           | null                                 | null                        
 | null                               | INVALID: `typed_value` is present for 
non-object |
-| INVALID                                                                      
      | `02 00` (object with 0 fields)    | null          |                     
           |                                      |                             
 |                                    | INVALID: `typed_value` is null for 
object        |
+| INVALID CASE: `{"event_type": "login", "event_ts": 1729795057774}`           
      | `{"event_type": "login"}`         | non-null      | null                
           | `login`                              | null                        
 | 1729795057774                      | INVALID: Shredded field is present in 
`value`    |

Review Comment:
   Notes now flighting all invalid cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to