amousavigourabi commented on code in PR #1141:
URL: https://github.com/apache/parquet-java/pull/1141#discussion_r2569894431
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputFormat.java:
##########
@@ -193,18 +195,13 @@ public static Class<?>
getUnboundRecordFilter(Configuration configuration) {
return ConfigurationUtil.getClassFromConfig(configuration,
UNBOUND_RECORD_FILTER, UnboundRecordFilter.class);
}
- private static UnboundRecordFilter
getUnboundRecordFilterInstance(Configuration configuration) {
+ private static UnboundRecordFilter
getUnboundRecordFilterInstance(ParquetConfiguration configuration) {
Class<?> clazz = ConfigurationUtil.getClassFromConfig(configuration,
UNBOUND_RECORD_FILTER, UnboundRecordFilter.class);
- if (clazz == null) { return null; }
-
+ if (clazz == null) {
+ return null;
+ }
try {
- UnboundRecordFilter unboundRecordFilter = (UnboundRecordFilter)
clazz.newInstance();
-
- if (unboundRecordFilter instanceof Configurable) {
- ((Configurable)unboundRecordFilter).setConf(configuration);
Review Comment:
looking back, i haven't a clue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
