emkornfield commented on code in PR #535:
URL: https://github.com/apache/parquet-format/pull/535#discussion_r2594172149
##########
src/main/thrift/parquet.thrift:
##########
@@ -715,6 +715,13 @@ struct DictionaryPageHeader {
* New page format allowing reading levels without decompressing the data
* Repetition and definition levels are uncompressed
* The remaining section containing the data is compressed if is_compressed is
true
+ *
+ * Implementation note - this header is not necessarily a strict improvement
over
+ * DataPageHeader in all cases (in particular the original header might
provide better compression
Review Comment:
```suggestion
* `DataPageHeader` (in particular the original header might provide better
compression
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
