emkornfield commented on code in PR #544: URL: https://github.com/apache/parquet-format/pull/544#discussion_r2677169843
########## src/main/flatbuf/parquet3.fbs: ########## @@ -0,0 +1,224 @@ +namespace parquet.format3; + +// Optimization notes +// 1. Statistics are stored in integral types if their size is fixed, otherwise prefix + suffix +// 2. ColumnMetaData.encoding_stats are removed, they are replaced with +// ColumnMetaData.is_fully_dict_encoded. +// 3. RowGroups are limited to 2GB in size, so we can use int for sizes. Review Comment: I think this and the item below are out of date (we are using `long` now) and can keep things absolute? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
