pitrou commented on issue #547: URL: https://github.com/apache/parquet-format/issues/547#issuecomment-3767413124
> i have updated my pull request to reflect [@jbapple](https://github.com/jbapple) 's code to estimate the fpp and shown that the adjustment is indeed in some cases necessary Is it actually necessary, though? If I look at: ``` NDV: 100, Target FPP: 0.01 Naive: 128 bytes, actual FPP: 0.011359 ❌ EXCEEDS TARGET Compensated: 256 bytes, actual FPP: 0.000371 ✓ meets target ``` then sure, 0.011359 is above the target but it's quite close, while 0.000371 is a lot smaller. Unless the target is considered an absolute maximum, then I'm not sure the "naive" computation is a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
