alamb opened a new pull request, #555:
URL: https://github.com/apache/parquet-format/pull/555

   
   ### Rationale for this change
   - @wgtmac pointed out in 
https://github.com/apache/parquet-site/pull/171#discussion_r2845743793  
   
   That the example of the `VARAINT` type annotation in this repository did not 
have a version
   
   I double checked and the VARAINT logical type does indeed have a logical 
type: 
https://github.com/apache/parquet-format/blob/38818fa0e7efd54b535001a4448030a40619c2a3/src/main/thrift/parquet.thrift#L409-L413
   
   This is also consistent with the parquet-java tests:
   
   
https://github.com/apache/parquet-java/blob/7148464a6b1a795f0058a811de2215d111b976ce/parquet-avro/src/test/java/org/apache/parquet/avro/TestReadVariant.java#L295
   
   
https://github.com/apache/parquet-java/blob/7148464a6b1a795f0058a811de2215d111b976ce/parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java#L455
   
   ### What changes are included in this PR?
   
   Updated the representation of unshredded and shredded Variants in the 
example to include the variant version
   
   ### Do these changes have PoC implementations?
   
   No this does not change the spec at all, just the examples


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to