alamb commented on code in PR #558:
URL: https://github.com/apache/parquet-format/pull/558#discussion_r2961436412
##########
src/main/thrift/parquet.thrift:
##########
@@ -280,7 +280,7 @@ struct Statistics {
*/
1: optional binary max;
2: optional binary min;
- /**
+ /**
Review Comment:
using `git blame -w` does indeed correctly ignore whitespace differences:
```shell
git blame -w src/main/thrift/parquet.thrift
...
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17
18:21:15 -0700 267) struct Statistics {
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 268) /**
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 269) * DEPRECATED: min and max value of the column. Use
min_value and max_value.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 270) *
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 271) * Values are encoded using PLAIN encoding, except that
variable-length byte
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 272) * arrays do not include a length prefix.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 273) *
bef54389 src/main/thrift/parquet.thrift (Zoltan Ivanfi 2017-10-06
16:38:53 -0700 274) * These fields encode min and max values determined by
signed comparison
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 275) * only. New files should use the correct order for a
column's logical type
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 276) * and store the values in the min_value and max_value
fields.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 277) *
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 278) * To support older readers, these may be set when the
column order is
bef54389 src/main/thrift/parquet.thrift (Zoltan Ivanfi 2017-10-06
16:38:53 -0700 279) * signed.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17
11:23:41 -0700 280) */
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17
18:21:15 -0700 281) 1: optional binary max;
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17
18:21:15 -0700 282) 2: optional binary min;
db687874 src/main/thrift/parquet.thrift (mwish 2024-08-23
15:30:20 +0800 283) /**
db687874 src/main/thrift/parquet.thrift (mwish 2024-08-23
15:30:20 +0800 284) * Count of null values in the column.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
