Fokko commented on code in PR #3548: URL: https://github.com/apache/parquet-java/pull/3548#discussion_r3288368423
########## .github/workflows/release-cancel-rc.yml: ########## @@ -0,0 +1,86 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: Release - Cancel RC + +on: + workflow_dispatch: + inputs: + version: + description: 'Release version (e.g., 1.18.0)' + required: true + type: string + rc_number: + description: 'RC number to cancel (e.g., 0)' + required: true + type: string + staging_repo_id: + description: 'Nexus staging repository ID to drop (e.g., orgapacheparquet-1234)' + required: true + type: string + allow_description_mismatch: + description: 'Bypass the staging-repo description check (recovery only)' + required: false + type: boolean + default: false + dry_run: + description: 'Dry run mode (no actual changes)' + required: false + type: boolean + default: true + +concurrency: + group: release-${{ inputs.version }} + cancel-in-progress: false + +jobs: + cancel-rc: + if: github.repository_owner == 'apache' + name: Cancel Release Candidate + runs-on: ubuntu-latest + permissions: + contents: read + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + persist-credentials: false + + - name: Install Subversion + run: sudo apt-get update && sudo apt-get install -y subversion Review Comment: apt-get is pretty verbose, how about only showing the errors? ```suggestion run: sudo apt-get update -q && sudo apt-get install -q -y subversion ``` ########## .github/workflows/ci-release-scripts.yml: ########## @@ -0,0 +1,64 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: Test Release Scripts + +on: + pull_request: + paths: + - 'release/**' + push: + branches: + - master + paths: + - 'release/**' + +jobs: + bats: + name: Release Script Unit Tests + runs-on: ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Install bats-core + run: | + sudo apt-get update + sudo apt-get install -y bats Review Comment: apt-get is pretty chatty, how about running this with only showing the errors: ```suggestion run: sudo apt-get update -q && sudo apt-get install -q -y bats ``` ########## .github/workflows/release-prepare-rc.yml: ########## @@ -0,0 +1,94 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: Release - Prepare RC + +on: + workflow_dispatch: + inputs: + version: + description: 'Release version (e.g., 1.18.0)' + required: true + type: string + rc_number: + description: 'RC number override (leave empty for auto-detect)' + required: false + type: string + default: '' + dry_run: + description: 'Dry run mode (no actual changes)' + required: false + type: boolean + default: true + +concurrency: + group: release-${{ inputs.version }} + cancel-in-progress: false + +jobs: + prepare-rc: + if: github.repository_owner == 'apache' + name: Prepare Release Candidate + runs-on: ubuntu-latest + permissions: + contents: write + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + token: ${{ secrets.GITHUB_TOKEN }} + + - name: Set up JDK 11 + uses: actions/setup-java@v4 + with: + distribution: temurin + java-version: '11' + + - name: Import GPG key and configure Git + env: + GPG_PRIVATE_KEY: ${{ secrets.PARQUET_GPG_PRIVATE_KEY }} + run: | + echo "${GPG_PRIVATE_KEY}" | gpg --batch --import + KEY_ID=$(gpg --list-keys --with-colons | grep '^fpr' | head -1 | cut -d: -f10) + git config --global user.name "github-actions[bot]" + git config --global user.email "github-actions[bot]@users.noreply.github.com" + git config --global user.signingkey "${KEY_ID}" + git config --global commit.gpgsign true + + - name: Install Subversion + run: sudo apt-get update && sudo apt-get install -y subversion Review Comment: apt-get is pretty verbose, how about only showing the errors? ```suggestion run: sudo apt-get update -q && sudo apt-get install -q -y subversion ``` ########## .github/workflows/release-publish.yml: ########## @@ -0,0 +1,102 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: Release - Publish After Vote + +on: + workflow_dispatch: + inputs: + version: + description: 'Release version (e.g., 1.18.0)' + required: true + type: string + rc_number: + description: 'RC number that passed the vote (leave empty to auto-detect latest)' + required: false + type: string + default: '' + staging_repo_id: + description: 'Nexus staging repository ID (e.g., orgapacheparquet-1234)' + required: true + type: string + allow_description_mismatch: + description: 'Bypass the staging-repo description check (recovery only)' + required: false + type: boolean + default: false + dry_run: + description: 'Dry run mode (no actual changes)' + required: false + type: boolean + default: true + +concurrency: + group: release-${{ inputs.version }} + cancel-in-progress: false + +jobs: + publish-release: + if: github.repository_owner == 'apache' + name: Publish Release + runs-on: ubuntu-latest + permissions: + contents: write + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + with: + fetch-depth: 0 + token: ${{ secrets.GITHUB_TOKEN }} + + - name: Set up JDK 11 + uses: actions/setup-java@v4 + with: + distribution: temurin + java-version: '11' + + - name: Install Subversion + run: sudo apt-get update && sudo apt-get install -y subversion Review Comment: apt-get is pretty verbose, how about only showing the errors? ```suggestion run: sudo apt-get update -q && sudo apt-get install -q -y subversion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
