wgtmac commented on code in PR #3607:
URL: https://github.com/apache/parquet-java/pull/3607#discussion_r3370610745
##########
parquet-column/src/main/java/org/apache/parquet/CorruptStatistics.java:
##########
@@ -35,6 +36,8 @@
*/
public class CorruptStatistics {
private static final AtomicBoolean alreadyLogged = new AtomicBoolean(false);
+ private static final ConcurrentHashMap<String, Boolean> CACHE = new
ConcurrentHashMap<>();
Review Comment:
Instead of caching the result, is it better to parse this once and cache a
flag somewhere in the reader so that it is shared by all columns associated
with that reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
