wgtmac commented on code in PR #578: URL: https://github.com/apache/parquet-format/pull/578#discussion_r3373792323
########## BinaryProtocolExtensions.md: ########## @@ -26,11 +26,17 @@ The extension mechanism of the `binary` Thrift field-id `32767` has some desirab * The content of the extension is freeform and can be encoded in any format. This format is not restricted to Thrift. * Extensions can be appended to existing Thrift serialized structs [without requiring Thrift libraries](#appending-extensions-to-thrift) for manipulation (or changes to the thrift IDL). -Because only one field-id is reserved the extension bytes themselves require disambiguation; otherwise readers will not be able to decode extensions safely. This is left to implementers which MUST put enough unique state in their extension bytes for disambiguation. This can be relatively easily achieved by adding a [UUID](https://en.wikipedia.org/wiki/Universally\_unique\_identifier) at the start or end of the extension bytes. The extension does not specify a disambiguation mechanism to allow more flexibility to implementers. +Because only one field-id is reserved the extension bytes themselves require Review Comment: Should we revert this change? Other lines do not seem to wrap lines like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
