alamb commented on code in PR #581:
URL: https://github.com/apache/parquet-format/pull/581#discussion_r3380753667


##########
src/main/thrift/parquet.thrift:
##########
@@ -1363,16 +1363,38 @@ union EncryptionAlgorithm {
  * Description for file metadata
  */
 struct FileMetaData {
-  /** Version of this file
+  /** Major Parquet Format Version
     *
-    * As of December 2025, there is no agreed upon consensus of what 
constitutes
-    * version 2 of the file. For maximum compatibility with readers, writers 
should
-    * always populate "1" for version. For maximum compatibility with writers,
-    * readers should accept "1" and "2" interchangeably.  All other versions 
are
-    * reserved for potential future use-cases.
+    * This corresponds to the highest major version of the parquet-format whose
+    * features the file uses. For example, if a file contains features from 
parquet-format
+    * version 2.4, then this field should be set to "2".
+    *
+    * Prior to 2026, some readers supported features added in version 2.0 and
+    * greater, but would reject files with the version set to 2. It was common
+    * practice for writers to populate "1" for version even if they used 
version
+    * 2.0.
+    *
+    * For maximum compatibility with writers, readers should accept "1" and "2"
+    * interchangeably.  All other versions are reserved for potential future
+    * use-cases.
     */
   1: required i32 version
 
+  /** Minor Parquet Format Version
+    *
+    * This corresponds to the highest minor version of the parquet-format whose
+    * features the file uses. For example, if a file contains features from
+    * parquet-format version 2.4, then this field should be set to "4".
+    *
+    * Note that Parquet does not follow semantic versioning and new
+    * forward-incompatible features, such as new encodings, can be added in
+    * minor versions. See the documentation[1] for more details on the 
versioning
+    * scheme and the features added in each version.
+    *
+    * [1]: http://parquet.apache.org/docs/file-format/versions

Review Comment:
   This URL would correspond to https://github.com/apache/parquet-site/pull/186 
when published



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to