alamb opened a new pull request, #582: URL: https://github.com/apache/parquet-format/pull/582
### Rationale for this change - Part of https://github.com/apache/parquet-format/issues/384 **NOTE**: there is an alternate RFC here - https://github.com/apache/parquet-format/pull/581 As described on the [mailing list thread](https://lists.apache.org/thread/st8l40z5n4cx5c22rcog50ws4pkzdc3s) about versions, there is currently no way for a parquet reader to know which if the many parquet features it may encounter in a particular file The current `version` field in the thirft metadata is insufficient because: 2. There is no agreed upon definition of `version` and many writers use it incorrectly: https://github.com/apache/parquet-format/blob/74001e41f5c5a1856b29be115f9c992cab16a4bf/src/main/thrift/parquet.thrift#L1368-L1373 1. Even if we agreed to use the `version` field, version "`2`" has several forward incompatible changes (see https://github.com/apache/parquet-site/pull/186) meaning a reader doesn't know what features it may encounter ### What changes are included in this PR? Add net new `format_major_version` and `format_minor_version` fields to the thrift metadata to encode the version of parquet-format. Readers can use this field to determine what features it may encounter. ## Open questions: * Guidance for writing with maximum compatibility (set `version` to 2 and then use major/minor version?) * Should new versions of parquet-format require writers to set this field? * Would we ever change the `version` field? These field would be ignored by older readers ### Do these changes have PoC implementations? Not yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
