iemejia commented on code in PR #3571:
URL: https://github.com/apache/parquet-java/pull/3571#discussion_r3402577582
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java:
##########
@@ -465,7 +466,7 @@ public void writeToFileWriter(ParquetFileWriter writer)
throws IOException {
if (LOG.isDebugEnabled()) {
LOG.debug(String.format(
"written %,dB for %s: %,d values, %,dB raw, %,dB comp, %d
pages, encodings: %s",
- buf.size(),
+ bytesWritten,
Review Comment:
`buf.size()` is captured before the write because `writeColumnChunk`
internally calls `buf.writeAllTo(out)` which progressively releases each slab
and resets `size` to 0 (see `ConcatenatingByteBufferCollector.writeAllTo`, line
103). If we called `buf.size()` inside the debug block after the write, it
would always report 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
