nastra commented on code in PR #3617:
URL: https://github.com/apache/parquet-java/pull/3617#discussion_r3441403780
##########
parquet-variant/src/test/java/org/apache/parquet/variant/TestVariantParseJson.java:
##########
@@ -212,59 +210,59 @@ public void testParseComplexDocument() throws IOException
{
+ "{\"eType\":\"purchase\",\"amount\":99.99}"
+ "]}";
Variant v = VariantJsonParser.parseJson(json);
- Assert.assertEquals(Variant.Type.OBJECT, v.getType());
- Assert.assertEquals(12345, v.getFieldByKey("userId").getLong());
+ assertThat(v.getType()).isEqualTo(Variant.Type.OBJECT);
+ assertThat(v.getFieldByKey("userId").getLong()).isEqualTo(12345);
Variant events = v.getFieldByKey("events");
- Assert.assertEquals(Variant.Type.ARRAY, events.getType());
- Assert.assertEquals(2, events.numArrayElements());
- Assert.assertEquals(
- "login",
events.getElementAtIndex(0).getFieldByKey("eType").getString());
- Assert.assertEquals(
- 0,
- new BigDecimal("99.99")
- .compareTo(events.getElementAtIndex(1)
- .getFieldByKey("amount")
- .getDecimal()));
+ assertThat(events.getType()).isEqualTo(Variant.Type.ARRAY);
+ assertThat(events.numArrayElements()).isEqualTo(2);
+ assertThat(events.getElementAtIndex(0).getFieldByKey("eType").getString())
+ .isEqualTo("login");
+
assertThat(events.getElementAtIndex(1).getFieldByKey("amount").getDecimal())
+ .isEqualTo(new BigDecimal("99.99"));
}
@Test
public void testParseEmptyString() throws IOException {
Variant v = VariantJsonParser.parseJson("\"\"");
- Assert.assertEquals(Variant.Type.STRING, v.getType());
- Assert.assertEquals("", v.getString());
+ assertThat(v.getType()).isEqualTo(Variant.Type.STRING);
+ assertThat(v.getString()).isEqualTo("");
}
@Test
public void testParseUnicodeString() throws IOException {
Variant v = VariantJsonParser.parseJson("\"\\u00e9l\\u00e8ve\"");
- Assert.assertEquals(Variant.Type.STRING, v.getType());
- Assert.assertEquals("\u00e9l\u00e8ve", v.getString());
+ assertThat(v.getType()).isEqualTo(Variant.Type.STRING);
+ assertThat(v.getString()).isEqualTo("\u00e9l\u00e8ve");
}
@Test
public void testParseUnicodeKey() throws IOException {
Variant v = VariantJsonParser.parseJson("{\"\\u00e9l\\u00e8ve\": 42}");
- Assert.assertEquals(Variant.Type.OBJECT, v.getType());
+ assertThat(v.getType()).isEqualTo(Variant.Type.OBJECT);
Variant value = v.getFieldByKey("élève");
- Assert.assertNotNull(value);
- Assert.assertEquals(42, value.getInt());
+ assertThat(value).isNotNull();
+ assertThat(value.getInt()).isEqualTo(42);
}
@Test
public void testParseEscapedString() throws IOException {
Variant v = VariantJsonParser.parseJson("\"hello\\nworld\"");
- Assert.assertEquals(Variant.Type.STRING, v.getType());
- Assert.assertEquals("hello\nworld", v.getString());
+ assertThat(v.getType()).isEqualTo(Variant.Type.STRING);
+ assertThat(v.getString()).isEqualTo("hello\nworld");
}
- @Test(expected = IOException.class)
- public void testParseMalformedJson() throws IOException {
- VariantJsonParser.parseJson("{invalid");
+ @Test
+ public void testParseMalformedJson() {
+ assertThatThrownBy(() -> VariantJsonParser.parseJson("{invalid"))
+ .isInstanceOf(IOException.class)
+ .hasMessageContaining("was expecting double-quote to start field
name");
}
- @Test(expected = IOException.class)
Review Comment:
we're also more explicit here in terms of testing failure conditions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
