nastra commented on code in PR #3619:
URL: https://github.com/apache/parquet-java/pull/3619#discussion_r3441624063
##########
pom.xml:
##########
@@ -158,9 +159,15 @@
<dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
Review Comment:
the vintage engine runs JUnit4 tests while the jupiter engine runs JUnit5
tests. Having both dependencies allows for easier and gradual migrations of
JUnit4 -> JUnit5 test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
