njlaw opened a new pull request, #3622: URL: https://github.com/apache/parquet-java/pull/3622
<!-- Thanks for opening a pull request! If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose and format pull request title as below: GH-${GITHUB_ISSUE_ID}: ${SUMMARY} or simply use the title below if it is a minor issue: MINOR: ${SUMMARY} --> ### Rationale for this change The `endField` method pushes the current field onto the `previousField` queue, which is used to maintain track of the previous field for each level of nesting with groups; however, the pushed fields are never removed from the queue, so it grows without bound. ### What changes are included in this PR? When `endField()` is called, it now replaces the previous field for the current nesting depth instead of appending a field. ### Are these changes tested? I added a test that verifies the `previousField` size is 0 after processing a message; however, the test requires introspection, which feels wrong. I'm open to suggestions! ### Are there any user-facing changes? No, there are no user-facing changes. Closes #3621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
