wgtmac commented on code in PR #3629:
URL: https://github.com/apache/parquet-java/pull/3629#discussion_r3464415915
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java:
##########
@@ -410,9 +410,14 @@ void setReleaser(ByteBufferReleaser releaser) {
@Override
public void close() {
- for (ColumnChunkPageReader reader : readers.values()) {
- reader.releaseBuffers();
+ try {
+ for (ColumnChunkPageReader reader : readers.values()) {
Review Comment:
Can we keep closing the remaining readers if one `releaseBuffers()` call
fails? As written, a failure still leaves later readers unreleased, and a
`releaser.close()` failure would hide the original exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
