gszadovszky commented on PR #3393: URL: https://github.com/apache/parquet-java/pull/3393#issuecomment-4790423917
Thanks @wgtmac for the updates. I think one issue remains with `NaN`s in the dictionary. We "canonicalize" the NaN values in the dictionary filter. So, if there are `NaN` and `-NaN` values in the dictionary, and the filter has a range predicate (e.g. `> 0`), we may drop the row group even if there should be a match based on the total ordering. We probably need to allow a "might match" explicitly if any `NaN` values are in the dictionary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
