rok commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3547224471
##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,21 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to an external file.
+ * The group must contain the following fields identified by name:
+ * - path (STRING, required): an opaque string path to the file (e.g.
s3://bucket/file.jpg)
Review Comment:
I think [Rfc for URI](https://datatracker.ietf.org/doc/html/rfc3986) covers
all cases mentioned.
We could specify something like
> A URI-reference as defined by RFC 3986, encoded as a Parquet STRING. If
absolute, it identifies an external resource. If relative, readers must resolve
it against the URI of the Parquet file containing this value using RFC 3986
section 5. If `uri` is not set, the value refers to the current Parquet file.
>
> Readers may support an implementation-defined set of URI schemes. If the
scheme is unsupported or the base URI is unavailable for a relative reference,
the value is not resolvable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
