nastra commented on code in PR #3654:
URL: https://github.com/apache/parquet-java/pull/3654#discussion_r3549597652
##########
parquet-common/src/test/java/org/apache/parquet/glob/TestGlob.java:
##########
@@ -31,45 +29,44 @@ public class TestGlob {
@Test
public void testNoGlobs() {
- assertEquals(List.of("foo"), Strings.expandGlob("foo"));
+ assertThat(Strings.expandGlob("foo")).containsExactly("foo");
}
@Test
public void testEmptyGroup() {
- assertEquals(List.of(""), Strings.expandGlob(""));
- assertEquals(List.of(""), Strings.expandGlob("{}"));
- assertEquals(List.of("a"), Strings.expandGlob("a{}"));
- assertEquals(List.of("ab"), Strings.expandGlob("a{}b"));
- assertEquals(List.of("a"), Strings.expandGlob("{}a"));
- assertEquals(List.of("a"), Strings.expandGlob("a{}"));
- assertEquals(List.of("", ""), Strings.expandGlob("{,}"));
- assertEquals(List.of("ab", "a", "ac"), Strings.expandGlob("a{b,{},c}"));
+ assertThat(Strings.expandGlob("")).containsExactly("");
+ assertThat(Strings.expandGlob("{}")).containsExactly("");
+ assertThat(Strings.expandGlob("a{}")).containsExactly("a");
+ assertThat(Strings.expandGlob("a{}b")).containsExactly("ab");
+ assertThat(Strings.expandGlob("{}a")).containsExactly("a");
+ assertThat(Strings.expandGlob("a{}")).containsExactly("a");
+ assertThat(Strings.expandGlob("{,}")).containsExactly("", "");
+ assertThat(Strings.expandGlob("a{b,{},c}")).containsExactly("ab", "a",
"ac");
Review Comment:
we don't need to compare against actual lists. It's easier to just verify
that the `actual` contains those elements in that specified order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
