etseidl commented on code in PR #3669:
URL: https://github.com/apache/parquet-java/pull/3669#discussion_r3605408178
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -1343,7 +1343,12 @@ LogicalTypeAnnotation
getLogicalTypeAnnotation(ConvertedType type, SchemaElement
}
LogicalTypeAnnotation getLogicalTypeAnnotation(LogicalType type) {
- switch (type.getSetField()) {
+ LogicalType._Fields setField = type.getSetField();
+ if (setField == null) {
Review Comment:
Would it be simpler to just change the `default` case to return null rather
than throwing an exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
