dossett commented on code in PR #3678:
URL: https://github.com/apache/parquet-java/pull/3678#discussion_r3624709914
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/util/TestHadoopOpenFile.java:
##########
@@ -101,10 +102,41 @@ public void testOpenFileGoodPath() throws Throwable {
// this looks up the FS binding via the status file path.
openAndRead(fileFromStatus());
+ assertThat(opener.getFileStatus()).as("file status").isSameAs(status);
+
// The fallback call of open(path) never took place.
Mockito.verify(mockFS, never()).open(path);
}
+ /**
+ * A caller-supplied length avoids a status lookup and is passed to
openFile().
+ */
+ @Test
+ public void testOpenFileWithKnownLength() throws Throwable {
Review Comment:
Added a test for local fs, it's not clear how to test the cloud store
behavior strictly with a unit test. Neither GCS nor S3 provides a
`MiniDFSCluster`-type tool as best I can tell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
