Fokko commented on code in PR #3694: URL: https://github.com/apache/parquet-java/pull/3694#discussion_r3663191794
########## parquet-cli/src/main/resources/META-INF/NOTICE: ########## @@ -43,3 +43,82 @@ notice: | See the License for the specific language governing permissions and | limitations under the License. +-------------------------------------------------------------------------------- + +This product bundles Apache Avro, which includes the following in its NOTICE Review Comment: This is an interpretation of the legalese around what needs to be included in the LICENSE/NOTICE. Please note that a lot of projects do this differently. My interpretation of it. For the ASF it is **required** for all the 3rd party source that is bundled with the source itself (so, borrowing a class from Avro etc) should be noted in the `LICENSE`. Since the ASF mostly cares around the source distribution, it is a bit of a gray area on how to handle the binary distribution where we include 3rd party binary because of bundling (in the `bundle` or `runtime` jar) or shading (mostly `FastUtil`). Some licenses explicitly call out that the license should be included when when binary distributed (eg, the [BSD-2 Clause](https://opensource.org/license/BSD-2-Clause): _Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution_. So, including these makes sure that we adhere to all the requirements. The big downside is that the LICENSE and NOTICE grow pretty big, which should be avoided according to the [`{LICENSE,NOTICE}` assembling how-to](https://infra.apache.org/licensing-howto.html). Since Parquet only has two packages (`parquet-hadoop-bundle` and `parquet-cli-runtime`) that ship a reasonable amound of 3rd party packages, I don't think it is an issue of having a somewhat bigger LICENSE and NOTICE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
