nssalian commented on code in PR #113:
URL: https://github.com/apache/parquet-testing/pull/113#discussion_r3677666685


##########
bad_data/README.md:
##########
@@ -35,3 +35,31 @@ These are files used for reproducing various bugs that have 
been reported.
   where repetition levels start with a 1 instead of 0.
 * ARROW-GH-47662.parquet: test case identified in 
https://github.com/apache/arrow/issues/47662
   where a required column contains null values (an incorrect version of 
data/fixed_length_byte_array.parquet).
+
+
+## Directory `variants`
+
+This subdirectory contains files with malformed variant structures.
+
+Robust implementations of variant decoders SHOULD reject these.
+
+| File                                                          | Malformed 
Structure                                                        |
+|---------------------------------------------------------------|----------------------------------------------------------------------------|

Review Comment:
   Agreed but those are in the tests of the Java repo. The data/README here has 
a snippet of the code that was used to generate the files. I'd prefer that be 
here rather than link to another repo. I'm okay reusing the same code but 
having it here is better for users to reproduce the artifacts. If you are 
planning to do that after the code merges, that's great.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to