asifsmohammed commented on code in PR #3700:
URL: https://github.com/apache/parquet-java/pull/3700#discussion_r3833146609
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -945,7 +947,25 @@ public static
org.apache.parquet.column.statistics.Statistics fromParquetStatist
// Visible for testing
static org.apache.parquet.column.statistics.Statistics
fromParquetStatisticsInternal(
String createdBy, Statistics formatStats, PrimitiveType type, SortOrder
typeSortOrder) {
- // create stats object based on the column type
+ return fromParquetStatisticsInternal(
+ CorruptStatistics.shouldIgnoreStatistics(createdBy,
type.getPrimitiveTypeName()),
Review Comment:
Moved `shouldIgnoreStatistics` evaluation inside the V1 legacy min/max
branch, V2 stats now bypass it entirely. Added
`testV2StatsDoNotTriggerCorruptStatisticsCheck` regression test that verifies a
corrupt writer version with V2 stats still gets valid min/max without consuming
the one-shot warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
