divjotarora commented on PR #3709: URL: https://github.com/apache/parquet-java/pull/3709#issuecomment-5486593333
@rdblue Thanks for the review! You raised a few big points, I'll recap them all here rather than replying to individual comments: 1. Release validation: the release check to ensure parquet-java tracks a released version of parquet-format was a suggestion from the mailing list [thread](https://lists.apache.org/thread/nkpkqz4fn9t9pcg7d16t8kwgmth86pn7). I audited the C++ and Rust implementations and didn't find a matching check there, so I've removed it. 2. Update script: I've removed the `--version` argument and now the update script just takes a single ref (either a full commit SHA or a tag) and it just downloads the corresponding `parquet.thrift`. I've also removed the retry logic. 3. Sidecar file: the `parquet-format.version` sidecar file now only stores a commit SHA, not a semantic version. In the case that the update script is invoked with a tag ref, it's first resolved to the corresponding SHA and that's stored in the sidecar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
