RyanSkraba commented on code in PR #3731:
URL: https://github.com/apache/parquet-java/pull/3731#discussion_r3903735260
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java:
##########
@@ -787,7 +787,8 @@ public void end() {
} else if (elementClass == double.class) {
parent.add(((DoubleArrayList) container).toDoubleArray());
} else {
- parent.add(((ArrayList) container).toArray());
+ parent.add(((ArrayList) container)
Review Comment:
N.B. The cast to ArrayList isn't necessary.
This line change is due to a bugfix in Avro, tightening up the permitted
values when setting reflected fields. The right thing to do here is to put an
array of the actual type in the container (as opposed to Object[]).
The TestReflectLogicalTypes#testReadUUIDArray fails here without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
