divjotarora commented on code in PR #3728: URL: https://github.com/apache/parquet-java/pull/3728#discussion_r3907667875
########## AGENTS.md: ########## Review Comment: I agree with @dossett that this is likely too much testing-specific info in a top-level `AGENTS.md`. The suggestion to move it to a separate file that can lazy loaded only when writing tests sounds reasonable. Additionally, we're mixing a lot of information about writing new tests vs. migrating existing ones. Perhaps it would make sense to separate these? Even if all of this info goes into a `TESTING_GUIDELINES.md` file or something but in separate sections, it would be more readable. Lastly, there's a few "MUST" rules in here (e.g. every `assertThatThrownBy` must contain an `isInstanceOf` chain + msg check). Do we have linter rules for these rather than just putting them in agent guidelines? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
