dossett commented on PR #3750:
URL: https://github.com/apache/parquet-java/pull/3750#issuecomment-5528559863
I'm always interested in parquet-protobuf work. I asked Codex to scrutinize
this PR and according to that analysis it's possible to write records that
can't be read back yet.
```java
@Test
public void emptyMessageRoundTripsThroughProtoReader() throws Exception {
Trees.StubBox expected = Trees.StubBox.newBuilder()
.setStub(Trees.Stub.getDefaultInstance())
.build();
Path file = write(true, expected);
assertThat(TestUtils.readMessages(file, Trees.StubBox.class))
.containsExactly(expected);
}
```
The read fails because when `ProtoMessagerConverter` is eventually called it
still expects a Parquet group and cast case the binary column. I confirmed
this unit test fails against this PR branch.
The unit test fails on `master` at the write step, which this PR does
address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
