abstractdog commented on PR #3782: URL: https://github.com/apache/parquet-java/pull/3782#issuecomment-5580939695
> Thanks for raising this PR @abstractdog, very interesting. Any way to verify using tests that we don't change hashes? good catch! addressed in https://github.com/apache/parquet-java/pull/3782/changes/f94e189a52e9d2f9598131ec8c18bb32ab9f13dd the test cases now validate against a fixed truth (generated by `scalarHashCode`), also checked pre/post patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
