vinooganesh opened a new pull request, #3791: URL: https://github.com/apache/parquet-java/pull/3791
Brings the inlined `parquet.thrift` up from parquet-format 2.13.0 to 2.14.0, via `dev/update-parquet-thrift.sh apache-parquet-format-2.14.0`. The file is byte-identical to upstream at that tag, and the sidecar is repinned accordingly. That picks up three format additions: the FILE logical type, INT96 chronological ordering, and the ALP encoding. Two small Java changes come with it: - `FILE` now exists in the `LogicalType` union. Before the bump a file using it fell into the unrecognised-logical-type branch and was ignored, preserving the physical type; afterwards it was a recognised member with no case and would have thrown. It is now ignored explicitly, so reader behaviour is unchanged. Covered by a test. - `ALP` is in the format enum but has no `org.apache.parquet.column.Encoding` counterpart yet, so `testEnumEquivalence` has nothing to round trip it through. It skips ALP for now. The skip is temporary and is removed by #3397, which adds the Java side. No behaviour changes otherwise. Full parquet-hadoop suite passes (746 tests), clean build, RAT and spotless clean. @RussellSpitzer this is the precursor you asked for on #3397, so that the ALP entry comes from upstream rather than being a local addition. It turned out it cannot be thrift only: bumping on a clean master fails `testEnumEquivalence` with `No enum constant org.apache.parquet.column.Encoding.ALP`, because the generated enum gains ALP(10) while the hand written one has none, and adding that constant pulls in the ALP readers. Hence the temporary skip here, which #3397 removes along with the local block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
