sankalpsthakur opened a new pull request, #3800:
URL: https://github.com/apache/parquet-java/pull/3800

   ### Rationale for this change
   
   https://github.com/apache/parquet-java/issues/3587 reports that 
`parquet.thrift.string.size.limit = -1` (the documented “use default”) was 
rejected as a non-positive value. The validation fix landed in #3588, but that 
PR used `Closes #GH-3587`, so GitHub never linked or closed the issue.
   
   This change pins the `-1` sentinel at the `Util` read path (the original 
throw site) and documents it on the public API.
   
   ### What changes are included in this PR?
   
   - Document that `Util.readFileMetaData(InputStream, int)` treats `-1` as the 
default 100 MB limit.
   - Add unit tests: `-1` succeeds, `0` and other negatives still fail.
   
   ### Are these changes tested?
   
   Yes.
   
   - `parquet-format-structures` `TestUtil`: Tests run: 5, Failures: 0
   - `parquet-hadoop` `TestParquetFileReaderMaxMessageSize`: Tests run: 6, 
Failures: 0
   
   ### Are there any user-facing changes?
   
   Javadoc only. No format or behavior change relative to current master.
   
   Contributor: Sankalp Thakur (`sankalpsthakur`). Apache ICLA note: this 
contribution is offered under the Apache License 2.0; please confirm ICLA 
status against ASF records if required for merge.
   
   Closes #3587
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to