rok commented on code in PR #624:
URL: https://github.com/apache/parquet-format/pull/624#discussion_r4075644673
##########
src/main/thrift/parquet.thrift:
##########
@@ -314,6 +314,9 @@ struct Statistics {
* or DOUBLE, or logical type is FLOAT16.
* If this field is not present, readers MUST assume NaNs may be present
* (i.e. MUST assume nan_count > 0 and MAY NOT assume nan_count == 0).
+ * If the column is the element leaf of a VECTOR, whose elements MUST by
+ * convention always be finite (see LogicalTypes.md) nan_count MUST be
+ * zero when present.
Review Comment:
@RussellSpitzer how about this?
```suggestion
* (i.e. MUST assume nan_count > 0 and MAY NOT assume nan_count == 0).
* If the column is the element leaf of a VECTOR, whose elements MUST by
* convention always be finite (see LogicalTypes.md) writers SHOULD omit
* nan_count field and readers MAY assume nan_count == 0.
```
##########
src/main/thrift/parquet.thrift:
##########
@@ -1366,7 +1387,10 @@ struct ColumnIndex {
* A list containing the number of NaN values for each page. Only present
* for columns of physical type FLOAT or DOUBLE, or logical type FLOAT16.
* If this field is not present, readers MUST assume that there might be
- * NaN values in any page.
+ * NaN values in any page, except if the column is an element leaf of a
+ * VECTOR, whose elements MUST by convention always be finite (see
+ * LogicalTypes.md). For such a column, every entry in nan_counts MUST
+ * be zero when present.
Review Comment:
@RussellSpitzer continued from above
```suggestion
* NaN values in any page, except if the column is an element leaf of a
* VECTOR, whose elements MUST by convention always be finite (see
* LogicalTypes.md), writers SHOULD omit nan_counts field and
* readers MAY assume nan_counts == 0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
