divjotarora commented on code in PR #624:
URL: https://github.com/apache/parquet-format/pull/624#discussion_r4112719542
##########
src/main/thrift/parquet.thrift:
##########
@@ -314,6 +314,12 @@ struct Statistics {
* or DOUBLE, or logical type is FLOAT16.
* If this field is not present, readers MUST assume NaNs may be present
* (i.e. MUST assume nan_count > 0 and MAY NOT assume nan_count == 0).
+ * If the column is the element leaf of a VECTOR, whose elements MUST by
+ * convention always be finite (see LogicalTypes.md) nan_count MUST be
+ * zero when present.
+ * If the column is the element leaf of a VECTOR, whose elements MUST by
+ * convention always be finite (see LogicalTypes.md) writers SHOULD omit
Review Comment:
+1, the current wording feels too specific / repetitive. First sentence
says if `nan_count` is set, it must be 0. Second one says writers should omit
`nan_count` and readers may assume it's 0. Can we just remove all of this?
Agreed that writers likely won't emit `nan_count` for vectors and when they do,
it's 0 by design. Anything non-zero is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
