puskarpeter opened a new pull request, #3844:
URL: https://github.com/apache/parquet-java/pull/3844

   ### Rationale for this change
   
   Backport of #3750 and #3752 to 1.18.x. Both are clean cherry-picks of the 
master commits (c3def131 and 398b63ef), no conflicts. They are bundled because 
#3752 builds on #3750 and cannot be applied without it.
   
   Both fix bugs that affect 1.18.x users today:
   
   - #2142: a message containing a field of an empty message type cannot be 
written at all (`InvalidSchemaException: Cannot write a schema with an empty 
group`), and files with `maxRecursion` truncation cannot be read back by 
`ProtoParquetReader`.
   - #3751: recursion truncation crashes with a `ClassCastException` for 
repeated recursive fields in specs-compliant mode, and corrupts the file in the 
old schema style.
   
   Could you please cherry-pick the two commits onto `parquet-1.18.x` as they 
are instead of squash-merging, so each fix keeps its own commit like on master?
   
   ### What changes are included in this PR?
   
   - GH-2142: Write fields of empty message types as proto bytes (#3750)
   - GH-3751: Preserve field repetition when truncating recursive proto fields 
(#3752)
   
   ### Are these changes tested?
   
   Yes, the tests from both PRs are included. The full parquet-protobuf suite 
passes on this branch, built with `--release 11`.
   
   ### Are there any user-facing changes?
   
   Same as #3750 and #3752.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to