divjotarora commented on code in PR #3831: URL: https://github.com/apache/parquet-java/pull/3831#discussion_r4268549852
########## parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetWriterAppendBlocks.java: ########## Review Comment: Let's also add a test that covers projecting just one of the colliding paths and copying that? In today's code, copying the full schema vs. a projection has different failure modes: the former fails with an error about missing columns while the latter succeeds and copies data that might be incorrect. With the fix in this PR, we can verify that (1) copying the full file successfully copies both columns and (2) copying a projection successfully copies the correct projected data without collisions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
