Fokko opened a new pull request, #3905: URL: https://github.com/apache/parquet-java/pull/3905
### Rationale for this change `ProtoSchemaConverter` was the only main-code Guava user in parquet-protobuf. It used `ImmutableSetMultimap` only to track which message types were seen at which recursion depth. ### What changes are included in this PR? Replace it with an immutable `Map<String, Set<Integer>>` that is copied on add, so sibling branches still don't see each other's entries. The Guava dependency stays at compile scope on purpose: `elephant-bird-core`, which parquet-protobuf uses at runtime, depends on Guava. Making it test scope would make downstream users resolve elephant-bird's Guava 11.0.1. ### Are these changes tested? Covered by the existing parquet-protobuf tests, including the recursion tests (`ProtoRecursionTruncationTest`, `ProtoSchemaConverterTest`). ### Are there any user-facing changes? No. Closes #3899 This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
