Fokko opened a new pull request, #3906:
URL: https://github.com/apache/parquet-java/pull/3906

   ### Rationale for this change
   
   Most of parquet-cli's Guava usage has a direct JDK 17 equivalent.
   
   ### What changes are included in this PR?
   
   - `Lists` / `Maps` / `Sets` factories become JDK constructors. `Immutable*` 
becomes `List` / `Set` / `Map.of` / `copyOf`, only where the collection is 
never iterated for output or never holds nulls; ordered output keeps 
`LinkedHashMap`.
   - `Joiner` / `Splitter` become `String.join` / `String.split(..., -1)`. 
`MoreObjects` / `Objects` become `java.util.Objects` or a plain `toString`.
   - Guava's `Preconditions` becomes `org.apache.parquet.Preconditions` / 
`Objects.requireNonNull`.
   - Guava imports in `parquet-cli/src/main` go from 85 to 15. The kept ones 
have no clean JDK equivalent: `Closeables.close(x, threw)`, `CharMatcher`, 
`Ascii`, `HashCode`, `CharStreams`, `Resources`, `Iterators.transform` and 
`VisibleForTesting`.
   
   ### Are these changes tested?
   
   Covered by the existing parquet-cli test suite.
   
   ### Are there any user-facing changes?
   
   No.
   
   Closes #3900
   
   This pull request and its description were written by Isaac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to