manuzhang opened a new pull request, #3930:
URL: https://github.com/apache/parquet-java/pull/3930
### Rationale for this change
The release commit 490699b8 ("Set version to 1.18.2 for release"), which is
the current head of `parquet-1.18.x`, did more than bump the 18 POM versions.
It also committed `thrift-0.25.0/`: 3,550 files (about 332 MB unpacked),
including 40 compiled x86-64 `.o` files and the files Thrift's `configure`
generates. The prepare-RC workflow had built Thrift inside the checkout, and
`prepare-rc.sh` staged the version bump with `git add -A`. The tree ended up in
the 1.18.2-rc0 source tarball (72.6 MB, against 1.4 MB for 1.18.1), so RC0
cannot be released.
Re-running the workflow for RC1 without this change would tag the same tree
again. The POMs are already at 1.18.2, so `prepare-rc.sh` skips the version
bump and tags the branch head.
### What changes are included in this PR?
- Removes `thrift-0.25.0/` and nothing else (deletions only).
After this PR, the branch tree matches 9ea3b783 (the commit before the
release bump) except for the 1.18.2 POM versions:
```
$ git diff --stat 9ea3b783 HEAD
18 files changed, 18 insertions(+), 18 deletions(-) # pom.xml files only
```
The removed files stay in history through 490699b8 and the
`apache-parquet-1.18.2-rc0` tag, but they are no longer in the tree that RC1
will be built from.
The workflow fix (build Thrift outside the checkout, stage with `git add
-u`, refuse to release from a dirty tree) is in #3929 against `master`. #3929
should be merged before 1.18.2-rc1 is prepared. Otherwise the workflow builds
Thrift in the checkout again, and the Nexus `source-release.zip`, which `mvn
deploy` builds from the files on disk, would still include it.
### Are these changes tested?
- `git diff --stat 9ea3b783 HEAD` shows only the 18 POM version changes, as
above.
- No `.o` files are left in the tree (`git ls-files | grep '\.o$'` is empty).
### Are there any user-facing changes?
No.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
